Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Default props bucket - #2623

Merged
jasonLaster merged 5 commits into
firefox-devtools:masterfrom
bomsy:default-props-bucket
Apr 11, 2017
Merged

Default props bucket#2623
jasonLaster merged 5 commits into
firefox-devtools:masterfrom
bomsy:default-props-bucket

Conversation

@bomsy

@bomsy bomsy commented Apr 11, 2017

Copy link
Copy Markdown
Contributor

Associated Issue: #2280

Summary of Changes

  • Added a function makeDefaultPropsBucket to render all the default properties under one [default properties] bucket
  • Numerical bucketing are only used for rendering large array objects
  • Updated the tests

Test Plan

  • Add this as a watch expression
  • Inspect its properties
  • Add a large array to the watch expressions
  • Inspect its contents

Screenshots/Videos

Before (example)
image

After (examples)
screen shot 2017-04-11 at 4 53 38 pm

this
screen shot 2017-04-11 at 4 56 49 pm
screen shot 2017-04-11 at 4 59 32 pm

@codecov

codecov Bot commented Apr 11, 2017

Copy link
Copy Markdown

Codecov Report

Merging #2623 into master will increase coverage by 0.41%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2623      +/-   ##
==========================================
+ Coverage   59.03%   59.44%   +0.41%     
==========================================
  Files          51       51              
  Lines        1943     1958      +15     
  Branches      398      400       +2     
==========================================
+ Hits         1147     1164      +17     
+ Misses        796      794       -2
Impacted Files Coverage Δ
src/utils/object-inspector.js 79.16% <100%> (+4.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a849101...85b9380. Read the comment docs.

@jasonLaster
jasonLaster merged commit f537109 into firefox-devtools:master Apr 11, 2017
@bomsy
bomsy deleted the default-props-bucket branch April 11, 2017 17:29
DanUgelow pushed a commit to DanUgelow/debugger.html that referenced this pull request May 4, 2017
* WIP bucketing window default properties, showing user defined properties

* fix most of the tests

* cleaner look for function previews
* use numerical buckets for only large arrays else use ordinary basic default props bucketing
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants