Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

basic fix for broken function preview - #2613

Merged
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
bomsy:fix-broken-func-preview
Apr 11, 2017
Merged

basic fix for broken function preview#2613
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
bomsy:fix-broken-func-preview

Conversation

@bomsy

@bomsy bomsy commented Apr 10, 2017

Copy link
Copy Markdown
Contributor

Associated Issue

This fixes the broken function preview, a possible regression.

Before

screen shot 2017-04-10 at 10 16 31 pm

After

screen shot 2017-04-10 at 10 14 57 pm

Summary of Changes

  • change div to span
  • use item instead of item.contents.value to get the function details for preview
  • If parameterNames does not exist the UI breaks

@codecov

codecov Bot commented Apr 10, 2017

Copy link
Copy Markdown

Codecov Report

Merging #2613 into master will decrease coverage by 0.48%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2613      +/-   ##
==========================================
- Coverage   59.03%   58.55%   -0.49%     
==========================================
  Files          51       51              
  Lines        1943     1959      +16     
  Branches      398      398              
==========================================
  Hits         1147     1147              
- Misses        796      812      +16
Impacted Files Coverage Δ
src/utils/editor/index.js 15.38% <0%> (-5.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a29fa0f...b051374. Read the comment docs.

@jasonLaster
jasonLaster merged commit 214ce13 into firefox-devtools:master Apr 11, 2017
@bomsy
bomsy deleted the fix-broken-func-preview branch April 11, 2017 10:04
DanUgelow pushed a commit to DanUgelow/debugger.html that referenced this pull request May 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants