Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Simplify function names - #2602

Merged
jbhoosreddy merged 1 commit into
firefox-devtools:masterfrom
jasonLaster:simplify-fn-name
Apr 9, 2017
Merged

Simplify function names#2602
jbhoosreddy merged 1 commit into
firefox-devtools:masterfrom
jasonLaster:simplify-fn-name

Conversation

@jasonLaster

Copy link
Copy Markdown
Contributor

Summary of Changes

  • This decodes Firefox's totally crazy interpretation of anonymous function names.
  • Why do decode the string, and not use babel
    • the string is a very clear spec with many rules, it is better than what we do w/ inference now
    • we don't want to load and parse every file we get in the call stack if we don't have to
  • will this work? if the regex's fail to match we'll show the original. This code will not throw errors. (i think)

Test Plan

You bet!

screen shot 2017-04-08 at 6 09 57 pm

Screenshots/Videos (OPTIONAL)

screen shot 2017-04-08 at 6 01 09 pm

@jbhoosreddy jbhoosreddy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jbhoosreddy
jbhoosreddy merged commit 28e7850 into firefox-devtools:master Apr 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants