Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Extract source editor - #2600

Merged
jbhoosreddy merged 1 commit into
firefox-devtools:masterfrom
jasonLaster:source-editor
Apr 9, 2017
Merged

Extract source editor#2600
jbhoosreddy merged 1 commit into
firefox-devtools:masterfrom
jasonLaster:source-editor

Conversation

@jasonLaster

@jasonLaster jasonLaster commented Apr 8, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

firefox-devtools/devtools-core#321

Summary of Changes

  • extracts the source editor so that the net monitor can use it
  • it is also simpler to think about a local editor and a panel editor
  • it will also make it easier to consolidate the local and panel editor down the road

CC @jbhoosreddy

jbhoosreddy
jbhoosreddy approved these changes Apr 9, 2017
View reviewed changes

@jbhoosreddy jbhoosreddy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jbhoosreddy
jbhoosreddy merged commit 92b92c0 into firefox-devtools:master Apr 9, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@jbhoosreddy jbhoosreddy jbhoosreddy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jasonLaster @jbhoosreddy