Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Object Inspector - Formatting Functions - #2597

Merged
jasonLaster merged 3 commits into
firefox-devtools:masterfrom
jacobjzhang:objInspectFormatFunc
Apr 8, 2017
Merged

Object Inspector - Formatting Functions#2597
jasonLaster merged 3 commits into
firefox-devtools:masterfrom
jacobjzhang:objInspectFormatFunc

Conversation

@jacobjzhang

Copy link
Copy Markdown
Contributor

Associated Issue: #2434

Summary of Changes

  • Switched display of functions in Object Inspector to be condensed
  • Styled the condensed version to be inline if in the object inspector.

Test Plan

  • Open the debugger and pause on any breakpoint
  • Look for functions in the scopes block

@codecov

codecov Bot commented Apr 8, 2017

Copy link
Copy Markdown

Codecov Report

Merging #2597 into master will decrease coverage by 0.08%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2597      +/-   ##
==========================================
- Coverage   57.76%   57.67%   -0.09%     
==========================================
  Files          51       51              
  Lines        1996     1999       +3     
  Branches      401      402       +1     
==========================================
  Hits         1153     1153              
- Misses        843      846       +3
Impacted Files Coverage Δ
src/utils/object-inspector.js 74.28% <0%> (-2.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6906d86...fdc190e. Read the comment docs.

@jasonLaster
jasonLaster merged commit 19a5a2e into firefox-devtools:master Apr 8, 2017
DanUgelow pushed a commit to DanUgelow/debugger.html that referenced this pull request May 4, 2017
* updating object inspector component and utility to allow for function preview formatting

* Making function signatures look pretty in the Scopes tab

* tweak
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants