This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Convert SearchBar to es6 - #2595
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2595 +/- ##
=======================================
Coverage 57.76% 57.76%
=======================================
Files 51 51
Lines 1996 1996
Branches 401 401
=======================================
Hits 1153 1153
Misses 843 843Continue to review full report at Codecov.
|
irfanhudda
reviewed
Apr 8, 2017
| import { isEnabled } from "devtools-config"; | ||
| import { filter } from "fuzzaldrin-plus"; | ||
| import Svg from "../shared/Svg"; | ||
| import { default as actions } from "../../actions"; |
Contributor
There was a problem hiding this comment.
Can we replace this with import actions from "../../actions"; ?
Contributor
Author
There was a problem hiding this comment.
Yeah, Nice catch. Thanks, I'll do a quick change.
jasonLaster
approved these changes
Apr 8, 2017
Contributor
|
Awesome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #1890
Summary of Changes