This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Fix/lint staged prettier - #2573
Merged
jasonLaster merged 4 commits intoApr 7, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2573 +/- ##
==========================================
- Coverage 57.76% 57.68% -0.09%
==========================================
Files 51 51
Lines 1996 1985 -11
Branches 401 398 -3
==========================================
- Hits 1153 1145 -8
+ Misses 843 840 -3
Continue to review full report at Codecov.
|
jasonLaster
reviewed
Apr 7, 2017
| "src/*.js": ["prettier", "git add"], | ||
| "src/*/*.js": ["prettier", "git add"], | ||
| "src/*/!(mochitest)**/*.js": ["prettier", "git add"], | ||
| "src/*/!(mochitest)*/**/*.js": ["prettier", "git add"] |
Contributor
There was a problem hiding this comment.
could we do a catch all like **/*.js which would pass everything to prettier?
Contributor
Author
There was a problem hiding this comment.
This won't ignore changes changes to the mochitests
DanUgelow
pushed a commit
to DanUgelow/debugger.html
that referenced
this pull request
May 4, 2017
* add dummy test * second test * 3rd test dummy * add lint-staged tasks for watching all oour prettier paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue
The issue is that lint-staged was not watching most of our prettier paths to automatically
make staged files in those files pretty.
Summary of Changes