This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Scoped expression evaluation - #2564
Merged
jasonLaster merged 2 commits intoApr 6, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2564 +/- ##
==========================================
+ Coverage 57.68% 57.74% +0.06%
==========================================
Files 51 51
Lines 1985 1988 +3
Branches 398 400 +2
==========================================
+ Hits 1145 1148 +3
Misses 840 840
Continue to review full report at Codecov.
|
jasonLaster
reviewed
Apr 6, 2017
|
|
||
| expect(selectors.getExpression(getState(), "foo").value).to.be(null); | ||
| expect(selectors.getExpression(getState(), "bar").value).to.be(null); | ||
| await dispatch(actions.evaluateExpressions("boo")); |
Contributor
There was a problem hiding this comment.
shouldn't this have a frame?
Contributor
Author
There was a problem hiding this comment.
i'm not sure how i'll mock the frame?
Contributor
There was a problem hiding this comment.
Ahh - i didnt see you were passing frameId in w/ boo. that's good enough for this test :)
DanUgelow
pushed a commit
to DanUgelow/debugger.html
that referenced
this pull request
May 4, 2017
* evaluate expressions in selected scope * fix lint issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #2265
Summary of Changes
evaluateExpressionsTest Plan