Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Convert ResultList to es6 class - #2548

Merged
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
irfanhudda:es6-resultlist
Apr 5, 2017
Merged

Convert ResultList to es6 class#2548
jasonLaster merged 1 commit into
firefox-devtools:masterfrom
irfanhudda:es6-resultlist

Conversation

@irfanhudda

Copy link
Copy Markdown
Contributor

Associated Issue: #1890

Summary of changes

  • Convert ResultList to ES6 class.
  • Additional changes for flow

@codecov

codecov Bot commented Apr 5, 2017

Copy link
Copy Markdown

Codecov Report

Merging #2548 into master will decrease coverage by 1.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2548      +/-   ##
==========================================
- Coverage   54.07%   52.96%   -1.12%     
==========================================
  Files          51       51              
  Lines        1986     1975      -11     
  Branches      398      395       -3     
==========================================
- Hits         1074     1046      -28     
- Misses        912      929      +17
Impacted Files Coverage Δ
src/utils/object-inspector.js 54.94% <0%> (-21.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1223468...41072b6. Read the comment docs.

@jasonLaster jasonLaster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@jasonLaster
jasonLaster merged commit e1e196f into firefox-devtools:master Apr 5, 2017
DanUgelow pushed a commit to DanUgelow/debugger.html that referenced this pull request May 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants