Fixes tabs dropdown button now shown onResize - #2492
Conversation
| minSize: 10, | ||
| maxSize: "50%", | ||
| splitterSize: 1, | ||
| onResize: onResize.bind(this, "start"), |
There was a problem hiding this comment.
hmm, maybe we should change this to be:
onResize: size => this.setState({startPanelSize: size})it's a little clenaer
| this.state = { | ||
| horizontal: verticalLayoutBreakpoint.matches, | ||
| startPanelSize: 0, | ||
| endPanelSize: 0, |
There was a problem hiding this comment.
I think @wldcordeiro might recommend that we put this state in the UI state.
What do you think?
There was a problem hiding this comment.
I wouldn't be against that, we already store that collapse state there.
Codecov Report
@@ Coverage Diff @@
## master #2492 +/- ##
=======================================
Coverage 57.68% 57.68%
=======================================
Files 51 51
Lines 1985 1985
Branches 398 398
=======================================
Hits 1145 1145
Misses 840 840Continue to review full report at Codecov.
|
jasonLaster
left a comment
There was a problem hiding this comment.
I still saw the issue with the fix:
| startPanelCollapsed, | ||
| endPanelCollapsed, | ||
| horizontal, | ||
| endPanelSize, |
There was a problem hiding this comment.
There was a problem hiding this comment.
It's working with updated devtools-core splitter package :)
|
I'll create a PR in devtools core, then it'll work fine. |
|
Thanks for the tweaks :) |
* Fixes tabs dropdown button not shown onResize * tweaks
Associated Issue: #2004
Summary of Changes
Test Plan