Skip to content

Commit 1bdfc56

Browse files
pierreluctgfelixdivo
authored andcommitted
Stop raising accuracy error for NeoVi (hardbyte#336)
Will only keep logging the error that ICS lib consider critical and no longer raise them. In most case, the error is affecting the accuracy but the device can still be use normally (i.e. Rx buffer overflow). In these cases, we do not want for example to kill a notifier using this bus, etc.
1 parent 60391e6 commit 1bdfc56

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

‎can/interfaces/ics_neovi/neovi_bus.py‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -188,8 +188,6 @@ def _process_msg_queue(self, timeout=0.1):
188188

189189
for msg in ics.get_error_messages(self.dev):
190190
error = ICSApiError(*msg)
191-
if error.is_critical:
192-
raise error
193191
logger.warning(error)
194192

195193
def _get_timestamp_for_msg(self, ics_msg):

0 commit comments

Comments
 (0)