Add eslint jest plugin (firefox-devtools#5010)

Author: jasonLaster

.eslintrc

@@ -1,12 +1,6 @@
 {
   "parser": "babel-eslint",
-  "plugins": [
-    "react",
-    "mozilla",
-    "flowtype",
-    "babel",
-    "prettier"
-  ],
+  "plugins": ["react", "mozilla", "flowtype", "babel", "prettier"],
   "globals": {
     "atob": true,
     "btoa": true,
@@ -35,18 +29,19 @@
   "extends": [
     "prettier",
     "prettier/flowtype",
-    "prettier/react"
+    "prettier/react",
+    "plugin:jest/recommended"
   ],
   "parserOptions": {
     "ecmaVersion": 2016,
     "sourceType": "module",
     "ecmaFeatures": { "jsx": true }
   },
   "env": {
-      "es6": true,
-      "browser": true,
-      "commonjs": true,
-      "jest": true
+    "es6": true,
+    "browser": true,
+    "commonjs": true,
+    "jest": true
   },
   "rules": {
     // These are the rules that have been configured so far to match the
@@ -68,16 +63,15 @@
     "react/no-direct-mutation-state": 1,
     "react/no-unknown-property": 1,
     "react/prop-types": 1,
-    "react/sort-comp": [1, {
-      order: [
-        "propTypes",
-        "everything-else",
-        "render"
-      ]
-    }],
+    "react/sort-comp": [
+      1,
+      {
+        order: ["propTypes", "everything-else", "render"]
+      }
+    ],
 
     // Enforce the spacing around the * in generator functions.
-    "babel/generator-star-spacing":  [2, "after"],
+    "babel/generator-star-spacing": [2, "after"],
 
     "flowtype/define-flow-type": 1,
     "flowtype/use-flow-type": 1,
@@ -125,7 +119,15 @@
     // rule is a better rule to check this.
     "max-depth": 0,
     // Maximum length of a line.
-    "max-len": [2, 80, 2, {"ignoreUrls": true, "ignorePattern": "\\s*require\\s*\\(|^\\s*loader\\.lazy|-\\*-"}],
+    "max-len": [
+      2,
+      80,
+      2,
+      {
+        "ignoreUrls": true,
+        "ignorePattern": "\\s*require\\s*\\(|^\\s*loader\\.lazy|-\\*-"
+      }
+    ],
     // Maximum depth callbacks can be nested.
     "max-nested-callbacks": [2, 3],
     // Don't limit the number of parameters that can be used in a function.
@@ -136,7 +138,7 @@
     // Require a capital letter for constructors, only check if all new
     // operators are followed by a capital letter. Don't warn when capitalized
     // functions are used without the new operator.
-    "new-cap": [2, {"capIsNew": false}],
+    "new-cap": [2, { "capIsNew": false }],
     // Disallow use of the Array constructor.
     "no-array-constructor": 2,
     // Allow use of bitwise operators.
@@ -211,10 +213,13 @@
     // Disallow use of multiline strings (use template strings instead).
     "no-multi-str": 2,
     "prefer-template": "error",
-    "prefer-const": ["error", {
-      "destructuring": "all",
-      "ignoreReadBeforeAssign": false
-    }],
+    "prefer-const": [
+      "error",
+      {
+        "destructuring": "all",
+        "ignoreReadBeforeAssign": false
+      }
+    ],
     // Disallow reassignments of native objects.
     "no-native-reassign": 2,
     // Disallow nested ternary expressions, they make the code hard to read.
@@ -287,7 +292,7 @@
     // statement.
     "no-unreachable": 2,
     // Disallow global and local variables that arent used, but allow unused function arguments.
-    "no-unused-vars": [2, {"vars": "all", "args": "none"}],
+    "no-unused-vars": [2, { "vars": "all", "args": "none" }],
     // Allow using variables before they are defined.
     "no-use-before-define": 0,
     // We use var-only-at-top-level instead of no-var as we allow top level

package.json

@@ -122,6 +122,7 @@
     "eslint-config-prettier": "^2.3.0",
     "eslint-plugin-babel": "^4.1.2",
     "eslint-plugin-flowtype": "^2.36.0",
+    "eslint-plugin-jest": "^21.5.0",
     "eslint-plugin-mozilla": "^0.4.4",
     "eslint-plugin-prettier": "^2.3.1",
     "eslint-plugin-react": "^7.2.1",

src/actions/breakpoints/tests/syncing.js

@@ -124,7 +124,7 @@ describe("loading the debugger", () => {
       pendingBreakpoint()
     );
 
-    expect(threadClient.removeBreakpoint.mock.calls.length).toBe(0);
+    expect(threadClient.removeBreakpoint.mock.calls).toHaveLength(0);
     expect(update).toMatchSnapshot();
   });
 
@@ -155,7 +155,7 @@ describe("loading the debugger", () => {
       pendingBreakpoint()
     );
 
-    expect(threadClient.removeBreakpoint.mock.calls.length).toBe(0);
+    expect(threadClient.removeBreakpoint.mock.calls).toHaveLength(0);
     expect(update.breakpoint.location.line).toBe(location.line + generated);
     expect(update).toMatchSnapshot();
   });
@@ -192,7 +192,7 @@ describe("reloading debuggee", () => {
       reloadedSource.id,
       pendingBreakpoint({ location: loc1 })
     );
-    expect(threadClient.removeBreakpoint.mock.calls.length).toBe(0);
+    expect(threadClient.removeBreakpoint.mock.calls).toHaveLength(0);
     expect(update).toMatchSnapshot();
   });
 
@@ -230,7 +230,7 @@ describe("reloading debuggee", () => {
       reloadedSource.id,
       pendingBreakpoint()
     );
-    expect(threadClient.removeBreakpoint.mock.calls.length).toBe(1);
+    expect(threadClient.removeBreakpoint.mock.calls).toHaveLength(1);
     expect(findScopeByName).toHaveBeenCalled();
     expect(update).toMatchSnapshot();
   });

src/actions/sources/tests/select.spec.js

@@ -43,7 +43,7 @@ describe("sources", () => {
         getOutOfScopeLocations(state) && getSourceMetaData(state, source.id)
     );
     const locations = getOutOfScopeLocations(getState());
-    expect(locations.length).toEqual(1);
+    expect(locations).toHaveLength(1);
   });
 
   it("should automatically select a pending source", async () => {

src/actions/tests/navigation.spec.js

@@ -1,9 +1,8 @@
 import { createStore, selectors, actions } from "../../utils/test-head";
-import expect from "expect.js";
 describe("navigation", () => {
   it("connect sets the debuggeeUrl", () => {
     const { dispatch, getState } = createStore();
     dispatch(actions.connect("http://test.com/foo"));
-    expect(selectors.getDebuggeeUrl(getState())).to.be("http://test.com/foo");
+    expect(selectors.getDebuggeeUrl(getState())).toEqual("http://test.com/foo");
   });
 });

src/actions/tests/pause.spec.js

@@ -57,7 +57,7 @@ describe("pause", () => {
       const { dispatch } = createStore(client);
 
       dispatch(actions.stepIn());
-      expect(client.stepIn.mock.calls.length).toEqual(0);
+      expect(client.stepIn.mock.calls).toHaveLength(0);
     });
 
     it("should step when paused", async () => {
@@ -78,7 +78,7 @@ describe("pause", () => {
 
       dispatch(actions.stepIn());
       await dispatch(actions.resumed());
-      expect(client.evaluate.mock.calls.length).toEqual(0);
+      expect(client.evaluate.mock.calls).toHaveLength(0);
     });
 
     it("resuming - will re-evaluate watch expressions", async () => {

src/client/firefox/tests/onconnect.spec.js

@@ -58,7 +58,7 @@ describe("firefox onConnect", () => {
       },
       actions
     );
-    expect(actions._sources.length).toEqual(1);
+    expect(actions._sources).toHaveLength(1);
     expect(actions._sources[0].url).toEqual("file:///tmp/s.js");
   });
 });

src/components/Editor/tests/Breakpoints.spec.js

@@ -33,15 +33,15 @@ describe("Breakpoints Component", () => {
     const breakpoints = I.Map({ id1: { location: { sourceId } } });
 
     const { component, props } = render({ breakpoints });
-    expect(component.find("Breakpoint").length).toBe(props.breakpoints.size);
+    expect(component.find("Breakpoint")).toHaveLength(props.breakpoints.size);
   });
 
   it("should render breakpoints with columns", async () => {
     const sourceId = "server1.conn1.child1/source1";
     const breakpoints = I.Map({ id1: { location: { column: 2, sourceId } } });
 
     const { component, props } = render({ breakpoints });
-    expect(component.find("Breakpoint").length).toBe(props.breakpoints.size);
+    expect(component.find("Breakpoint")).toHaveLength(props.breakpoints.size);
     expect(component).toMatchSnapshot();
   });
 });

src/components/ProjectSearch/textSearch/tests/__snapshots__/textSearch.spec.js.snap

@@ -19,25 +19,3 @@ exports[`project search - highlightMatches simple 1`] = `
   />
 </span>
 `;
-
-exports[`project search - highlightMatches simple 2`] = `
-<span
-  className="line-value"
->
-  <span
-    className="line-match"
-  >
-    lets 
-  </span>
-  <span
-    className="query-match"
-  >
-    foo
-  </span>
-  <span
-    className="line-match"
-  >
-     and then baa
-  </span>
-</span>
-`;

src/components/ProjectSearch/textSearch/tests/textSearch.spec.js

@@ -10,13 +10,3 @@ describe("project search - highlightMatches", () => {
     expect(highlightMatches(lineMatch)).toMatchSnapshot();
   });
 });
-describe("project search - highlightMatches", () => {
-  it("simple", () => {
-    const lineMatch = {
-      value: "lets foo and then baa",
-      column: 5,
-      match: "foo"
-    };
-    expect(highlightMatches(lineMatch)).toMatchSnapshot();
-  });
-});