clean out the utils/utils module using lodash utils where possible (firefox-devtools#2114)

* remove truncateStr function from utils/utils

`truncateStr` was only referenced in the docs

* use flow number to type endTruncateStr

* remove unused zip function from utils/utils

* replace toObject with lodash.fromPairs

src/utils/redux/middleware/promise.js was the only other file using
`toObject`

* remove unused mapObject function from utils/utils

* replace throttle with lodash/throttle

* optimize lodash usage to not pull in entire library

* use toPairs in middleware/promise

* use toPairs in utils/parser and drop entries function utils/utils

* remove unused compose function from utils/utils

* upgrade to latest lodash 4.17.4

* Revert "replace throttle with lodash/throttle"

This reverts commit e23d2e7.

Author: clarkbw

bin/getConfig.js

@@ -1,4 +1,4 @@
-const merge = require("lodash").merge;
+const merge = require("lodash/merge");
 const fs = require("fs");
 const path = require("path");
 

docs/local-development.md

@@ -342,7 +342,6 @@ index 8c79f4d..6893673 100644
 +const Svg = require("./shared/Svg");
  const { getSource, getPause, getBreakpoints } = require("../selectors");
  const { makeLocationId } = require("../reducers/breakpoints");
- const { truncateStr } = require("../utils/utils");
 @@ -89,6 +90,7 @@ const Breakpoints = React.createClass({
          key: locationId,
          onClick: () => this.selectBreakpoint(breakpoint)

package.json

@@ -55,7 +55,7 @@
     "fuzzaldrin-plus": "^0.4.1",
     "glob": "^7.0.3",
     "husky": "^0.13.1",
-    "lodash": "^4.13.1",
+    "lodash": "^4.17.4",
     "md5": "^2.2.1",
     "mocha": "^3.1.2",
     "mocha-circleci-reporter": "0.0.2",
@@ -89,6 +89,5 @@
     "remark-lint": "^6.0.0",
     "remark-preset-lint-recommended": "^1.0.0",
     "remark-validate-links": "^6.0.0"
-
   }
 }

src/utils/parser.js

@@ -4,7 +4,7 @@ const babylon = require("babylon");
 const traverse = require("babel-traverse").default;
 const t = require("babel-types");
 const { isDevelopment } = require("devtools-config");
-const { entries } = require("./utils");
+const toPairs = require("lodash/toPairs");
 const get = require("lodash/get");
 
 import type { SourceText, Source, Location } from "../types";
@@ -111,7 +111,7 @@ function getVariablesInScope(source: Source, location: Location) {
   const path = getPathClosestToLocation(source, location);
   const bindings = get(path, "scope.bindings", {});
 
-  return entries(bindings)
+  return toPairs(bindings)
     .map(([name, binding]) => ({
       name,
       references: binding.referencePaths

src/utils/redux/middleware/promise.js

@@ -5,7 +5,8 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 const defer = require("../../defer");
-const { entries, toObject } = require("../../utils");
+const toPairs = require("lodash/toPairs");
+const fromPairs = require("lodash/fromPairs");
 const { executeSoon } = require("../../DevToolsUtils");
 
 import type { ThunkArgs } from "../../../actions/types";
@@ -18,8 +19,8 @@ function seqIdGen() {
 }
 
 function filterAction(action: Object): Object {
-  return toObject(
-    entries(action).filter(pair => pair[0] !== PROMISE)
+  return fromPairs(
+    toPairs(action).filter(pair => pair[0] !== PROMISE)
   );
 }
 

src/utils/utils.js

@@ -39,18 +39,7 @@ function promisify(context: any, method: any, ...args: any) {
  * @memberof utils/utils
  * @static
  */
-function truncateStr(str: any, size: any) {
-  if (str.length > size) {
-    return `${str.slice(0, size)}...`;
-  }
-  return str;
-}
-
-/**
- * @memberof utils/utils
- * @static
- */
-function endTruncateStr(str: any, size: any) {
+function endTruncateStr(str: any, size: number) {
   if (str.length > size) {
     return `...${str.slice(str.length - size)}`;
   }
@@ -86,91 +75,6 @@ function workerTask(worker: any, method: string) {
   };
 }
 
-/**
- * Interleaves two arrays element by element, returning the combined array, like
- * a zip. In the case of arrays with different sizes, undefined values will be
- * interleaved at the end along with the extra values of the larger array.
- *
- * @param Array a
- * @param Array b
- * @returns Array
- *          The combined array, in the form [a1, b1, a2, b2, ...]
- * @memberof utils/utils
- * @static
- */
-function zip(a: any, b: any) {
-  if (!b) {
-    return a;
-  }
-  if (!a) {
-    return b;
-  }
-  const pairs = [];
-  for (let i = 0, aLength = a.length, bLength = b.length;
-       i < aLength || i < bLength;
-       i++) {
-    pairs.push([a[i], b[i]]);
-  }
-  return pairs;
-}
-
-/**
- * Converts an object into an array with 2-element arrays as key/value
- * pairs of the object. `{ foo: 1, bar: 2}` would become
- * `[[foo, 1], [bar 2]]` (order not guaranteed);
- *
- * @returns array
- * @memberof utils/utils
- * @static
- */
-function entries(obj: any) {
-  return Object.keys(obj).map(k => [k, obj[k]]);
-}
-
-/**
- * @memberof utils/utils
- * @static
- */
-function mapObject(obj: any, iteratee: any) {
-  return toObject(entries(obj).map(([key, value]) => {
-    return [key, iteratee(key, value)];
-  }));
-}
-
-/**
- * Takes an array of 2-element arrays as key/values pairs and
- * constructs an object using them.
- * @memberof utils/utils
- * @static
- */
-function toObject(arr: any) {
-  const obj = {};
-  for (let pair of arr) {
-    obj[pair[0]] = pair[1];
-  }
-  return obj;
-}
-
-/**
- * Composes the given functions into a single function, which will
- * apply the results of each function right-to-left, starting with
- * applying the given arguments to the right-most function.
- * `compose(foo, bar, baz)` === `args => foo(bar(baz(args)`
- *
- * @param ...function funcs
- * @returns function
- * @memberof utils/utils
- * @static
- */
-function compose(...funcs: any) {
-  return (...args: any) => {
-    const initialValue = funcs[funcs.length - 1].apply(null, args);
-    const leftFuncs = funcs.slice(0, -1);
-    return leftFuncs.reduceRight((composed, f) => f(composed),
-                                 initialValue);
-  };
-}
-
 /**
  * @memberof utils/utils
  * @static
@@ -203,14 +107,8 @@ function waitForMs(ms: number) {
 module.exports = {
   handleError,
   promisify,
-  truncateStr,
   endTruncateStr,
   workerTask,
-  zip,
-  entries,
-  toObject,
-  mapObject,
-  compose,
   updateObj,
   throttle,
   waitForMs

yarn.lock

@@ -3686,7 +3686,7 @@ lodash.uniq@^4.3.0:
   version "4.5.0"
   resolved "https://registry.yarnpkg.com/lodash.uniq/-/lodash.uniq-4.5.0.tgz#d0225373aeb652adc1bc82e4945339a842754773"
 
-lodash@^4.0.0, lodash@^4.1.0, lodash@^4.11.1, lodash@^4.13.1, lodash@^4.14.0, lodash@^4.15.0, lodash@^4.17.2, lodash@^4.2.0, lodash@^4.2.1, lodash@^4.3.0, lodash@^4.8.0, lodash@~4.17.2:
+lodash@^4.0.0, lodash@^4.1.0, lodash@^4.11.1, lodash@^4.14.0, lodash@^4.15.0, lodash@^4.17.2, lodash@^4.17.4, lodash@^4.2.0, lodash@^4.2.1, lodash@^4.3.0, lodash@^4.8.0, lodash@~4.17.2:
   version "4.17.4"
   resolved "https://registry.yarnpkg.com/lodash/-/lodash-4.17.4.tgz#78203a4d1c328ae1d86dca6460e369b57f4055ae"